[FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag
jamrial at gmail.com
Tue Jun 12 20:30:01 EEST 2018
On 6/12/2018 5:33 AM, Gyan Doshi wrote:
> On 12-06-2018 01:39 PM, Hendrik Leppkes wrote:
>> This flag is part of the public API, and eventhough it is entirely
>> unused, you cannot remove public API without a proper deprecation
> Ok, so looking at older flags, I need to
> add a define to version.h, something like
> #ifndef FF_API_LAVF_MP4A_LATM
> #define FF_API_LAVF_MP4A_LATM (LIBAVFORMAT_VERSION_MAJOR < 59)
> and place the flag under guard in avformat.h
> And place same guard in the options table.
Change the description of the option in this table into something like
"Deprecated, does nothing" while at it as well.
> Is that correct?
> I assume the other changes can be committed as-is.
Yes, that should do it.
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel