[FFmpeg-devel] [PATCH] cinepak_decode_init: check frame dimensions

Michael Niedermayer michael at niedermayer.cc
Wed Jun 13 04:06:06 EEST 2018


first please make sure you are subscribed to ffmpeg-devel if you want to
submit patches. submited patches are discussed on the ffmpeg-devel
mailing list almost always. People rarely think of CC-ing the author

then 2nd you should make sure you confirm both the bug you
are trying to fix as well as the fix with ffmpeg git master

is ffmpeg git master really affected by any of the bugs you are trying to fix?

also it is neccessary for you to understand the format you
are changing
and run tests to confirm that you are not breaking something.

The changes you are posting which i looked at so far are basically wrong.

we have cinepak files with odd resolutions even in the fate tests for example

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180613/5a345b13/attachment.sig>

More information about the ffmpeg-devel mailing list