[FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

Michael Niedermayer michael at niedermayer.cc
Tue Jun 26 20:29:57 EEST 2018


On Tue, Jun 26, 2018 at 07:02:38PM +0800, Baozeng Ding wrote:
> Signed-off-by: Baozeng Ding <sploving1 at gmail.com>
> ---
>  libavcodec/parser.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

This looks wrong. The input must have AV_INPUT_BUFFER_PADDING_SIZE
allocated at the end.

Is the buffer you pass into the parser large enough ?
this and the source code ive seen looked like it is too small

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180626/b6220bcb/attachment.sig>


More information about the ffmpeg-devel mailing list