[FFmpeg-devel] [PATCH 6/8] avformat/movenc: Do not pass AVCodecParameters in avpriv_request_sample

[Michael Niedermayer]

On Wed, Jun 27, 2018 at 03:54:06PM -0300, James Almer wrote:
> On 6/27/2018 3:11 PM, Michael Niedermayer wrote:
> > Fixes: out of array read
> > Fixes: ffmpeg_crash_8.avi
> > 
> > Found-by: Thuan Pham, Marcel Böhme, Andrew Santosa and Alexandru Razvan Caciulescu with AFLSmart
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/movenc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > index 00567db586..2603b9c95f 100644
> > --- a/libavformat/movenc.c
> > +++ b/libavformat/movenc.c
> > @@ -429,7 +429,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
> >  
> >              if (hdr->substreamid == info->num_ind_sub + 1) {
> >                  //info->num_ind_sub++;
> > -                avpriv_request_sample(track->par, "Multiple independent substreams");
> > +                avpriv_request_sample(mov, "Multiple independent substreams");
> 
> mov->fc
> 
> >                  ret = AVERROR_PATCHWELCOME;
> >                  goto end;
> >              } else if (hdr->substreamid < info->num_ind_sub ||
> > @@ -439,7 +439,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
> >              }
> >          } else {
> >              if (hdr->substreamid != 0) {
> > -                avpriv_request_sample(track->par, "Multiple dependent substreams");
> > +                avpriv_request_sample(mov, "Multiple dependent substreams");
> 
> Same.

will change it but this function used mov before. ill change that too

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180627/bf25174b/attachment.sig>