[FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

[Paul B Mahol]

On 3/12/18, James Almer <jamrial at gmail.com> wrote:
> On 3/12/2018 7:48 AM, Paul B Mahol wrote:
>> On 3/12/18, wm4 <nfxjfg at googlemail.com> wrote:
>>> On Mon, 12 Mar 2018 11:26:26 +0100
>>> Paul B Mahol <onemda at gmail.com> wrote:
>>>
>>>> On 3/12/18, Hazem Ashmawy <hazem.s.ashmawy at gmail.com> wrote:
>>>>> Specifications can be found here:
>>>>> https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md
>>>>>
>>>>> Signed-off-by: Hazem Ashmawy <hazem.s.ashmawy at gmail.com>
>>>>> ---
>>>>>  libavfilter/vf_panorama.c | 32 ++++++++++++++++----------------
>>>>>  1 file changed, 16 insertions(+), 16 deletions(-)
>>>>>
>>>>
>>>> Please post whole patch, not just recent changes.
>>>>
>>>> Or just link to github branch.
>>>
>>> Also, in comment on this whole issue: this is why it should use the
>>> libavutil spherical metadata, because then we have something rigorously
>>> defined. Just saying.
>>
>> I already wrote that can not be used, similar to stereo3d frame side
>> data for another filter.
>
> What are these avfilter limitations you speak of?
>
> The API for that matter follows the Google spec to the letter for
> Cubemap and Equirectangular projections. If they came up with some new
> projection definition not currently in the spec then they should be
> asked to make it official in said document, so we can implement it. Case
> in point the contents of this "ytmp" box in recent spherical mp4 streams
> they seem to be serving.
>
> In any case, please add a big TODO message to make sure this filter and
> the framework are eventually adapted to use the frame side data when
> available.

Sure.