[FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

[Michael Niedermayer]

On Mon, Mar 19, 2018 at 09:31:44AM +0100, Tobias Rapp wrote:
> On 14.03.2018 09:55, Tobias Rapp wrote:
> >Allows to set the AV_LOG_PRINT_LEVEL and AV_LOG_SKIP_REPEATED flags
> >using a distinct command-line option, similar to other flag options.
> >Previously only the AV_LOG_SKIP_REPEATED flag was supported as a prefix
> >to the "loglevel" option value.
> >
> >Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
> >---
> >  doc/fftools-common-opts.texi | 13 +++++++++++++
> >  fftools/cmdutils.c           | 31 +++++++++++++++++++++++++++++++
> >  fftools/cmdutils.h           |  6 ++++++
> >  3 files changed, 50 insertions(+)
> >
> >[...]
> 
> Any opinions? My motivation was adding support for AV_LOG_PRINT_LEVEL on the
> CLI. Using the existing flags option string parsing functions seemed easier
> and more consistent that extending the custom loglevel string parser.

this means the feature would require every user app to add similar code
if one wants to support it.

it would be better if apps do not need changes for added options

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180320/877d5bf0/attachment.sig>