[FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Mar 21 22:32:47 EET 2018


2018-03-21 14:37 GMT+01:00, Gyan Doshi <gyandoshi at gmail.com>:
> Fix for ticket 7091.

> -            film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 0 : 1;
> +            film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 1 : 0;

Can you comment on why this 15-year old code was wrong?

Could be keyframe = !!(scratch & 0x80)

Carl Eugen


More information about the ffmpeg-devel mailing list