[FFmpeg-devel] [PATCH v3 1/3] avutil/log: rename and initialize global log flags variable

Michael Niedermayer michael at niedermayer.cc
Thu Mar 29 21:40:12 EEST 2018


On Wed, Mar 28, 2018 at 05:03:38PM +0200, Tobias Rapp wrote:
> Rename global variable for symmetry with av_log_level.
> 
> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
> ---
>  libavutil/log.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libavutil/log.c b/libavutil/log.c
> index 9b7d484..0a99d01 100644
> --- a/libavutil/log.c
> +++ b/libavutil/log.c
> @@ -52,7 +52,7 @@ static AVMutex mutex = AV_MUTEX_INITIALIZER;
>  #endif
>  
>  static int av_log_level = AV_LOG_INFO;
> -static int flags;
> +static int av_log_flags = 0;

This prefix is confusing as the av prefix is intended for 
exported public symbols which a static symbol cannot be

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180329/5525d2f4/attachment.sig>


More information about the ffmpeg-devel mailing list