[FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

[Rostislav Pehlivanov]

On 3 May 2018 at 00:10, Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Wed, May 02, 2018 at 10:23:08PM +0100, Rostislav Pehlivanov wrote:
> > On 2 May 2018 at 21:19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> >
> > > 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
> > > > On 1 May 2018 at 21:58, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > > >
> > > >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov <
> atomnuker at gmail.com>:
> > > >> > Its a reminder of a bygone era. Less flexible than the internal RC
> > > >> > system, probably worse and most definitely broken. Drop it. No one
> > > >> > ever used it either, except for mislead people.
> > > >>
> > > >> Sorry for my bad git knowledge:
> > > >> Is the above part of the commit message?
> > > >>
> > > >> Carl Eugen
> > >
> > > > Yep, its part of the commit message.
> > >
> > > Then the patch cannot be committed as-is.
> > >
> >
> > Why?
> >
> >
> >
> > > Please wait for a comment from the maintainer, Carl Eugen
>

The commit message is (unnecessarily) offensive.
>

There's nothing offensive in there. Users are mislead because this option
exists because they think it'll give them better quality. It doesn't.


About the removial itself, its a question if theres someone who
> used/ wants to use this and wants to continue to use it.
> (thats something i do not know)
>

No one wanted to use it in the first place.


I certainly can look into fixing it if theres someone who uses this. In fact
> i was not aware of this being broken, but i think i havnt tested it for a
> long
> time so it very well could be broken.
>
> If OTOH noone uses / wants to use it then well there wouldnt be much point
> in keeping it
>

Removed the commit message altogether. I plan to apply this tomorrow unless
there are objections.