[FFmpeg-devel] [PATCH v2 04/10] lavfi/nlmeans: add AArch64 SIMD for compute_safe_ssd_integral_image

Michael Niedermayer michael at niedermayer.cc
Tue May 8 05:06:26 EEST 2018


On Mon, May 07, 2018 at 07:24:16PM +0200, Clément Bœsch wrote:
> ssd_integral_image_c: 49204.6
> ssd_integral_image_neon: 28346.8
> ---
>  libavfilter/aarch64/Makefile          |  3 +
>  libavfilter/aarch64/vf_nlmeans_init.c | 33 +++++++++++
>  libavfilter/aarch64/vf_nlmeans_neon.S | 80 +++++++++++++++++++++++++++
>  libavfilter/vf_nlmeans.c              | 26 ++++++---
>  libavfilter/vf_nlmeans.h              | 35 ++++++++++++
>  5 files changed, 170 insertions(+), 7 deletions(-)
>  create mode 100644 libavfilter/aarch64/Makefile
>  create mode 100644 libavfilter/aarch64/vf_nlmeans_init.c
>  create mode 100644 libavfilter/aarch64/vf_nlmeans_neon.S
>  create mode 100644 libavfilter/vf_nlmeans.h

seems to break make testprogs unless iam missing something

CC	libavfilter/tests/integral.o
libavfilter/tests/integral.c: In function ‘main’:
libavfilter/tests/integral.c:68:40: warning: passing argument 1 of ‘compute_ssd_integral_image’ from incompatible pointer type [enabled by default]
                                        src, lz, xoff, yoff, e, w, h);
                                        ^
In file included from libavfilter/tests/integral.c:19:0:
./libavfilter/vf_nlmeans.c:244:13: note: expected ‘const struct NLMeansDSPContext *’ but argument is of type ‘uint32_t *’
 static void compute_ssd_integral_image(const NLMeansDSPContext *dsp,
             ^
libavfilter/tests/integral.c:68:40: warning: passing argument 2 of ‘compute_ssd_integral_image’ makes pointer from integer without a cast [enabled by default]
                                        src, lz, xoff, yoff, e, w, h);
                                        ^
In file included from libavfilter/tests/integral.c:19:0:
./libavfilter/vf_nlmeans.c:244:13: note: expected ‘uint32_t *’ but argument is of type ‘int’
 static void compute_ssd_integral_image(const NLMeansDSPContext *dsp,
             ^
libavfilter/tests/integral.c:68:40: warning: passing argument 3 of ‘compute_ssd_integral_image’ makes integer from pointer without a cast [enabled by default]
                                        src, lz, xoff, yoff, e, w, h);
                                        ^
In file included from libavfilter/tests/integral.c:19:0:
./libavfilter/vf_nlmeans.c:244:13: note: expected ‘ptrdiff_t’ but argument is of type ‘const uint8_t *’
 static void compute_ssd_integral_image(const NLMeansDSPContext *dsp,
             ^
libavfilter/tests/integral.c:68:40: warning: passing argument 4 of ‘compute_ssd_integral_image’ makes pointer from integer without a cast [enabled by default]
                                        src, lz, xoff, yoff, e, w, h);
                                        ^
In file included from libavfilter/tests/integral.c:19:0:
./libavfilter/vf_nlmeans.c:244:13: note: expected ‘const uint8_t *’ but argument is of type ‘int’
 static void compute_ssd_integral_image(const NLMeansDSPContext *dsp,
             ^
libavfilter/tests/integral.c:68:40: error: too few arguments to function ‘compute_ssd_integral_image’
                                        src, lz, xoff, yoff, e, w, h);
                                        ^
In file included from libavfilter/tests/integral.c:19:0:
./libavfilter/vf_nlmeans.c:244:13: note: declared here
 static void compute_ssd_integral_image(const NLMeansDSPContext *dsp,
             ^
make: *** [libavfilter/tests/integral.o] Error 1
make: Target `testprogs' not remade because of errors.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/72dc9700/attachment.sig>


More information about the ffmpeg-devel mailing list