[FFmpeg-devel] [PATCH 06/13] avformat/mxfenc: Add Sample width/height/x offset/y offset, Display x offset and F2 offset

Michael Niedermayer michael at niedermayer.cc
Tue May 8 19:26:29 EEST 2018


On Tue, May 08, 2018 at 12:40:49PM +0200, Tomas Härdin wrote:
> mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > +    if (sc->interlaced) {
> > +        //Display F2 Offset
> > +        mxf_write_local_tag(pb, 4, 0x3217);
> > +        avio_wb32(pb, -((st->codecpar->height - display_height)&1));
> 
> Negative values for DisplayF2Offset are not valid

The specification (SMPTE 377-1-2009) says:

The DisplayF2Offset Property adjusts the DisplayYOffset for the second field relative to that for the first field. Its
value shall be zero (0) or minus 1. A value of minus 1 shall invert the Displayed Topness relative to the Sampled
Topness.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/880d6a53/attachment.sig>


More information about the ffmpeg-devel mailing list