[FFmpeg-devel] [PATCH v3 1/4] cbs_h265: read/write HEVC PREFIX SEI

[Xiang, Haihao]

On Thu, 2018-05-10 at 21:00 +0100, Mark Thompson wrote:
> On 10/05/18 06:47, Haihao Xiang wrote:
> > Similar to H264, cbs_h265_{read, write}_nal_unit() can handle HEVC
> > prefix SEI NAL units. Currently mastering display colour volume SEI
> > message is added only, we may add more SEI message if needed later
> > 
> > v2: Fix coding style and rebase the code
> > 
> > v3: Fix assertion failure when running the command below:
> > ffmpeg -i input-with-sei.mkv -c:v copy -bsf:v trace_headers -f null -
> > Fix the ranges for max_display_mastering_luminance and
> > min_display_mastering_luminance
> > 
> > Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
> > ---
> >  libavcodec/cbs_h2645.c                |  45 ++++++++++
> >  libavcodec/cbs_h265.h                 |  36 ++++++++
> >  libavcodec/cbs_h265_syntax_template.c | 158
> > ++++++++++++++++++++++++++++++++++
> >  3 files changed, 239 insertions(+)
> > 
> > ...
> >  
> > +typedef struct H265RawSEIMasteringDiplayColourVolume {
> 
> I fixed this typo                     ^^ which appears in several places (a
> bad feature of code completion, I guess :P ).
> 
> Then tested, all looks good, applied.

Thanks for catching and fixing this stupid typo, I should check spelling more
carefully. 

> 
> Thanks!
> 
> - Mark
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel