[FFmpeg-devel] [PATCH][ticket #5522] lavc/cfhd: interlaced frame decoding added

Gagandeep Singh deepgagan231197 at gmail.com
Wed May 23 04:46:59 EEST 2018


On Wed, 23 May 2018, 04:05 Carl Eugen Hoyos, <ceffmpeg at gmail.com> wrote:

> 2018-05-23 0:21 GMT+02:00, Hendrik Leppkes <h.leppkes at gmail.com>:
> > On Tue, May 22, 2018 at 10:35 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > wrote:
> >> 2018-05-22 17:40 GMT+02:00, Gagandeep Singh <deepgagan231197 at gmail.com
> >:
> >>
> >>> +            low    = s->plane[plane].subband[0];
> >>> +            high   = s->plane[plane].subband[8];
> >>> +            output = s->plane[plane].l_h[6];
> >>> +            for (i = 0; i < lowpass_width; i++) {
> >>> +                vert_filter(output, lowpass_width, low, lowpass_width,
> >>> high, highpass_stride, lowpass_height);
> >>> +                low++;
> >>> +                high++;
> >>> +                output++;
> >>> +            }
> >>>
> >>> -        low    = s->plane[plane].subband[0];
> >>> -        high   = s->plane[plane].subband[8];
> >>> -        output = s->plane[plane].l_h[6];
> >>> -        for (i = 0; i < lowpass_width; i++) {
> >>> -            vert_filter(output, lowpass_width, low, lowpass_width,
> high,
> >>> highpass_stride, lowpass_height);
> >>> -            low++;
> >>> -            high++;
> >>> -            output++;
> >>> -        }
> >>
> >> The patch will get much more readable (and easier to review)
> >> if you do not re-indent, instead send a second patch with the
> >> cosmetic changes only.
> >>
> >
> > Except, no sane developer works like that.
>
> It's great to know that you are so much smarter than most developers,
> I will forward the next regression directly to you to fix it.
>
> Thank you, Carl Eugen
>

I will keep the cosmetic patch also in mind next time

Gagandeep Singh

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list