[FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Remove muxer overhead from Bandwidth field in DASH manifest

Jeyapal, Karthick kjeyapal at akamai.com
Tue Sep 11 15:34:59 EEST 2018


On 9/4/18 1:45 PM, Karthick J wrote:
> From: Karthick Jeyapal <kjeyapal at akamai.com>
>
> Fixes bug id #7386
> Muxer overhead calculations was intented for HLS playlist as Apple's mediastreamvalidator tests were failing.
> But applying the same fix for DASH manifest proved counterproductive, as Bandwidth can be used for segment name templates.
> ---
>  libavformat/dashenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index c36ab12..2564b9e 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -611,7 +611,7 @@ static int write_adaptation_set(AVFormatContext *s, AVIOContext *out, int as_ind
>  
>          if (os->bit_rate > 0)
>              snprintf(bandwidth_str, sizeof(bandwidth_str), " bandwidth=\"%d\"",
> -                     os->bit_rate + os->muxer_overhead);
> +                     os->bit_rate);
>  
>          if (as->media_type == AVMEDIA_TYPE_VIDEO) {
>              AVStream *st = s->streams[i];

Pushed the patchset.

Regards,
Karthick



More information about the ffmpeg-devel mailing list