[FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

[Carl Eugen Hoyos]

2019-04-09 15:26 GMT+02:00, Shivam Goyal <shivgo at iitk.ac.in>:
>
> On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote:
>> 2019-04-09 11:36 GMT+02:00, Shivam Goyal <shivgo at iitk.ac.in>:

>> The following probably doesn't work for some very large files:
>>
>>> +    offset = ((avio_r8(ic) + rot & 0xff)<<24) |
>>> +             ((avio_r8(ic) + rot & 0xff)<<16) |
>>> +             ((avio_r8(ic) + rot & 0xff)<<8) |
>>> +             ((avio_r8(ic) + rot & 0xff)) + 0x200000;
>
>
>> I suggested:
>> offset = ((avio_r8(ic) + rot & 0xff) << 24 |
>>            (avio_r8(ic) + rot & 0xff) << 16) |
>>            (avio_r8(ic) + rot & 0xff) <<  8) |
>>            (avio_r8(ic) + rot & 0xff)) + 0x200000;
>
> The suggested notation is wrong

True, sorry.
offset = ((avio_r8(ic) + rot & 0xff) << 24 |
           (avio_r8(ic) + rot & 0xff) << 16 |
           (avio_r8(ic) + rot & 0xff) <<  8 |
           (avio_r8(ic) + rot & 0xff)) + 0x200000;

Carl Eugen