[FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: rework mxf_essence_container_end

Tomas Härdin tjoppen at acc.umu.se
Sun Apr 14 18:58:05 EEST 2019


fre 2019-04-12 klockan 01:09 +0200 skrev Marton Balint:
> We find the last essence container much faster if we go through the partitions
> backwards...

Good catch

> 
> > Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/mxfdec.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index c3892a1037..18c038c3f6 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1545,10 +1545,7 @@ static int mxf_absolute_bodysid_offset(MXFContext *mxf, int body_sid, int64_t of
>   */
>  static int64_t mxf_essence_container_end(MXFContext *mxf, int body_sid)
>  {
> -    int x;
> -    int64_t ret = 0;
> -
> -    for (x = 0; x < mxf->partitions_count; x++) {
> +    for (int x = mxf->partitions_count - 1; x >= 0; x--) {

This is C99, but I think we allow that these days. Maybe someone
objects? Else looks OK

/Tomas


More information about the ffmpeg-devel mailing list