[FFmpeg-devel] [PATCH 2/7] avformat/id3v2: Fix double-free on error

Michael Niedermayer michael at niedermayer.cc
Tue Dec 10 00:37:35 EET 2019


On Sun, Nov 10, 2019 at 05:07:28AM +0100, Andreas Rheinhardt wrote:
> ff_id3v2_parse_priv_dict() uses av_dict_set() with the flags
> AV_DICT_DONT_STRDUP_KEY and AV_DICT_DONT_STRDUP_VAL. In this case both
> key and value are freed on error (and owned by the destination
> dictionary on success), so that freeing them again on error is a
> double-free and therefore forbidden. But it nevertheless happened.
> 
> Fixes CID 1452489 and 1452421.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavformat/id3v2.c | 2 --
>  1 file changed, 2 deletions(-)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191209/ed9baa8c/attachment.sig>


More information about the ffmpeg-devel mailing list