[FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr for transform depth 4

[Thilo Borgmann]

Hi,

Am 12.12.19 um 08:27 schrieb Fu, Linjie:
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>> Carl Eugen Hoyos
>> Sent: Wednesday, December 11, 2019 18:19
>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr
>> for transform depth 4
>>
>> Am Mi., 11. Dez. 2019 um 09:57 Uhr schrieb Linjie Fu <linjie.fu at intel.com>:
>>>
>>> The max transform depth is 5(from 0 to 4), so we need 5 cabac states for
>>> cbf_cb and cbf_cr.
>>>
>>> See Table 9-4 for details.
>>
>> Does this change the output of a file?
>> If yes, please provide it / implement a fate test.
> 
> Yes, this issue was found in some license-limited clips and does affect the decoding. 
> Hence it takes some efforts to generate an available file for verifying/test in the
> community.
> 
> I've created a ticket for this and attached the clips and the decode result with/without
> this patch:
> https://trac.ffmpeg.org/ticket/8425
> 
> Please help to verify.

please add a fate test that uses your .h265 sample to verify decoding.

Have a look at previous patches adding fate tests if you are uncertain what to do.

I'll upload the sample once it is used in fate.

-Thilo