[FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

Jean-Baptiste Kempf jb at videolan.org
Mon Dec 16 23:53:26 EET 2019


On Mon, Dec 9, 2019, at 18:42, Sebastian Pop wrote:
> On Mon, Dec 9, 2019 at 5:01 AM Clément Bœsch <u at pkh.me> wrote:
> >
> > On Sun, Dec 08, 2019 at 11:08:31PM +0200, Martin Storsjö wrote:
> > > On Sun, 8 Dec 2019, Clément Bœsch wrote:
> > >
> > > > On Wed, Dec 04, 2019 at 05:24:46PM -0600, Sebastian Pop wrote:
> > > > > Hi Clément,
> > > > >
> > > > > please find attached the updated patch addressing all your comments.
> > > > > Let me know if there is anything else that I missed and that I need to address.
> > > > >
> > > >
> > > > I can't test but patch LGTM. Aside from the commit message: it's missing a
> > > > commit prefix (such as "swscale/aarch64: ...") and I'm not sure what this
> > > > "FMA" is referring to.
> > >
> > > FMA is a common acronym for "fused multiplication and addition", i.e. the
> > > MLA instruction in AArch64.
> >
> > Ah right, my bad, I thought the original code was already doing that.
> >
> 
> I replaced "FMA" with "multiply accumulate" in the subject line and added the
> prefix as recommended. Ok to commit?

As far as I am concerned, OK.

--
Jean-Baptiste Kempf - President
+33 672 704 734




More information about the ffmpeg-devel mailing list