[FFmpeg-devel] [PATCH 2/4 v2] avcodec/libx265: add a qp option and apply the relevant global AVCodecContext settings to the encoder context

[James Almer]

On 12/30/2019 8:10 PM, Derek Buitenhuis wrote:
> On 30/12/2019 19:20, James Almer wrote:
>> +        snprintf(cqp, sizeof(cqp), "%d", ctx->cqp);
>> +        if (ctx->api->param_parse(ctx->params, "qp", cqp) == X265_PARAM_BAD_VALUE) {
>> +            av_log(avctx, AV_LOG_ERROR, "Invalid cqp: %d.\n", ctx->cqp);
>> +            return AVERROR(EINVAL);
>> +        }
> 
> Is the reason this doesn't use parse_int so that this error message can be given?

I think i wrote this chunk (copy pasted from the crf one) before i
implemented parse_int(), so it kinda stayed like this. I'll replace it.

> 
> Otherwise, LGTM.
> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>