[FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

Baptiste Coudurier baptiste.coudurier at gmail.com
Tue Feb 5 20:42:32 EET 2019

Hi Niki,

> On Feb 4, 2019, at 6:03 PM, Niki Bowe <nbowe at google.com> wrote:
> Hi Baptiste. 
> I agree. This patch does cause it to fail in mov_write_header in the given example, by propagating the errors returned from mov_write_ac3_tag.
> It is not always extradata related.
> Eg EAC3 parses the packets during muxing to build the dec3 atom. Perhaps this should be made extradata, but its not today.
> A definitely not extradata related example: mov_write_tmcd_tag can fail for fps reasons.
> Many atom writing functions can fail and return error codes, but today very little error checking exists.

Ok, patch looks good to me.

Thanks a lot!

Baptiste Coudurier

More information about the ffmpeg-devel mailing list