[FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun
chcunningham at chromium.org
Thu Feb 7 21:30:32 EET 2019
This will reject the file entirely. The testcase I have (can share once
chromium bug is fixed) was previously hitting an av_assert0 in
mov_read_trun, arguably also a total rejection ;). Recovery for this could
be pretty tricky since the dropped trun will break decode dependencies. I
would be surprised to find files with missing tfhd's in the wild (outside
of fuzzer / maliciously crafted sorts).
On Thu, Feb 7, 2019 at 7:58 AM Derek Buitenhuis <derek.buitenhuis at gmail.com>
> On 07/02/2019 00:12, chcunningham wrote:
> > Detecting missing tfhd avoids re-using tfhd track info from the previous
> > moof. For files with multiple tracks, this may make a mess of the
> > avindex and fragindex, which can later trigger av_assert0 in
> > mov_read_trun().
> > ---
> > libavformat/isom.h | 1 +
> > libavformat/mov.c | 10 ++++++++++
> > 2 files changed, 11 insertions(+)
> I think this seems reasonable.
> Is the intent to entirely reject these files, or only the broken parts?
> (lack of patch context for how it cascades for me)
> - Derek
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel