[FFmpeg-devel] [PATCH]lavf/mpegts: Do not print the character coding as part of service name

[Carl Eugen Hoyos]

2019-02-08 0:11 GMT+01:00, Marton Balint <cus at passwd.hu>:
>
> On Thu, 7 Feb 2019, Carl Eugen Hoyos wrote:
>
>> 2019-02-07 21:40 GMT+01:00, Marton Balint <cus at passwd.hu>:

>>>> New patch attached.
>>>
>>> Don't simply drop charset information.
>>
>>> You should convert the strings to UTF-8 based on that.
>>
>> (Yes we should)
>> Do you have a sample that needs this?
>
> There are tons of samples that needs this, two examples:
>
> - samples/ffmpeg-bugs/roundup/issue1871/dvbt.ts
> - samples/MPEG2/res_change_ffmpeg_aspect.ts

These are cool, I found the one from ticket #2261 and
I realized that "ORF NÖ" also needs a conversion;-)

>> If not, a patch that fixes a user-reported issue would rot
>> because a better (unneeded) fix is possible.
>
> In this case I think an incomplete fix hurts more, because after it the
> API user will have no way to determine the encoding.

Removed the part of the patch that would have removed the "?"
for non-iconv and unknown encodings.

Carl Eugen