[FFmpeg-devel] [PATCH]lavf/img2dec: Split img2 and img2pipe options

Jan Ekström jeebjp at gmail.com
Sun Feb 10 02:55:48 EET 2019

On Sat, Feb 9, 2019 at 2:58 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> Hi!
> Currently if the "loop" option gets specified for -f image2pipe, there is
> no indication for the user that the option will not work, patch attached.
> Please comment, Carl Eugen

Seems like a good idea.

The reason for the pipe version's AVOption structure to be outside of
the if is the IMAGEAUTO_DEMUXER macro, so I guess unless we like
really long #ifs then this is as good as it gets.

Quickly checked and it seems like generally the separation of options
seems correct... but I'm not sure about "ts_from_file" . The filename
variable will probably be full of \0s at the point where stat() is
called, as it's only set to something else under "!s->is_pipe" branch
in the beginning of the function if I'm seeing correctly - thus making
this option effectively unusable under the _pipe demuxers?


More information about the ffmpeg-devel mailing list