[FFmpeg-devel] [PATCH] avformat/mov: fix sidx loading issues in fragmented files.
michaelni at gmx.at
Mon Feb 11 11:55:37 EET 2019
On Sat, Feb 09, 2019 at 11:44:52PM -0500, agrecascino123 at gmail.com wrote:
> From: mptcultist <agrecascino123 at gmail.com>
> fixed issue where if sidx was after another sidx and happened to point to the same media, it wouldn't be read.
> this is done by counting the sidx atoms before they're read. for #7572
> libavformat/isom.h | 2 ++
> libavformat/mov.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 45 insertions(+), 2 deletions(-)
this looks not ok as it effectivly doubles the number of passes over the whole file
also there is no need for this, doing a single pass either you are done or you
are not so its possible to know if all have been read.
If the existing check for the last sidx is wrong then it should be fixed.
also this patch only fixes the issue if seeking for a 2nd pass is supported
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel