[FFmpeg-devel] [PATCH]lavf/spdifenc: Use a more flexible buffer model for TrueHD/MAT

Hendrik Leppkes h.leppkes at gmail.com
Fri Feb 15 01:23:03 EET 2019

On Thu, Feb 14, 2019 at 8:11 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> Hi!
> I created attached patch with a lot of help from Hendrik, fixes ticket #7731.

Som general comments, since I can't replay inline in this mail client:

- The pseudo-timestamps are unsigned 16-bit, personally I would make
all types that reference them uint16_t and rely on unsigned overflow
behavior, which is fully valid and specified - no need to handle
negatives manually, etc.
- The distance between frames can be incredibly large in some streams,
I've seen it be larger then one whole MAT frame, and the output works
reliably (MAT start/middle/end codes need to be placed within the
padding space, of course).

There is a few more things I saw, but I'll respond to those from a
better client in a few days when I'm back home.

- Hendrik

More information about the ffmpeg-devel mailing list