[FFmpeg-devel] [PATCH v2] lavf/jacosubdec: compute subtitle duration correctly

Paul B Mahol onemda at gmail.com
Tue Feb 19 11:29:40 EET 2019


On 2/19/19, Adam Sampson <ats at offog.org> wrote:
> When a JACOsub subtitle has two timestamps, they represent its start and
> end times (http://unicorn.us.com/jacosub/jscripts.html#l_times); the
> duration is the difference between the two, not the sum of the two.
>
> The subtitle end times in the FATE test for this were wrong as a result;
> fix them too. (This test is based on JACOsub's demo.txt, and the end
> time computed for the last line using @ now matches what the comments
> there say it should be.)
>
> Also tested in practice using MPV, a LaserDisc, and some authentic 1993
> JACOsub files.
>
> Signed-off-by: Adam Sampson <ats at offog.org>
> ---
> v2: update the test data too (thanks, Carl Eugen!)
>
>  libavformat/jacosubdec.c   |  2 +-
>  tests/ref/fate/sub-jacosub | 22 +++++++++++-----------
>  2 files changed, 12 insertions(+), 12 deletions(-)
>

LGTM


More information about the ffmpeg-devel mailing list