[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

Derek Buitenhuis derek.buitenhuis at gmail.com
Wed Feb 27 19:57:06 EET 2019

On 27/02/2019 17:31, Gyan wrote:
> Yes, a string. 4 integers and qp offset so either two more, in rational 
> form, or a float.

You're assuming a single ROI, though, which is only one case. Plenty of things
would need >1.

> There's already multiple interfaces accepting long multi-entry 
> multi-valued arguments, whether custom ones in filters like curves or 
> pan, or x264opts, or with the assistance of an existing key-value parser 
> like x264-params. Unless the plan is to allow only machine-generated 
> ROIs, some form of manual user specification will be needed, and that 
> option will have to be prepared to accept and parse such a string.

Feel free to send a patch then I guess... it doesn't sound very appealing
to use them this way, and certaily not to manually add an AVOption for
every codec.

I am not convinced using it manually via CLI options is at all appealing.

- Derek

More information about the ffmpeg-devel mailing list