[FFmpeg-devel] [PATCH] Display decoded frame number on error

[Remi Achard]

> Rémi Achard (12019-07-12):
> > ---
> >  fftools/ffmpeg.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> > index 01f04103cf..aaeabe512b 100644
> > --- a/fftools/ffmpeg.c
> > +++ b/fftools/ffmpeg.c
> > @@ -2107,7 +2107,7 @@ static void check_decode_result(InputStream *ist,
> int *got_output, int ret)
> >      if (*got_output && ist) {
> >          if (ist->decoded_frame->decode_error_flags ||
> (ist->decoded_frame->flags & AV_FRAME_FLAG_CORRUPT)) {
> >              av_log(NULL, exit_on_error ? AV_LOG_FATAL : AV_LOG_WARNING,
> > -                   "%s: corrupt decoded frame in stream %d\n",
> input_files[ist->file_index]->ctx->url, ist->st->index);
>
> > +                   "%s: corrupt decoded frame %llu in stream %d\n",
> input_files[ist->file_index]->ctx->url, ist->frames_decoded + 1,
> ist->st->index);
>
> frames_decoded is uint64_t, not long long; %lld is for long long.


So I'm not supposed to use %llu as is the case here (sorry if I didn't
understood your point) ?


>
>
Also: what is the use case for this change?
>

The use case would be to improve error diagnostic, eg. when you want to
check a video integrity, you might want to know at what point in time
corruption occurs and there is currently no way of knowing this if I'm not
mistaken.


>
> >              if (exit_on_error)
> >                  exit_program(1);
> >          }
>
> Regards,
>