[FFmpeg-devel] [PATCH v1 2/2] fftools/ffmpeg Add stream metadata from first frame's metadata

[Jun Li]

On Sun, May 5, 2019 at 6:06 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Sat, May 04, 2019 at 07:13:34PM -0700, Jun Li wrote:
> > Fix #6945
> > Exif extension has 'Orientaion' field for image flip and rotation.
> > This change is to add the first frame's exif into stream so that
> > autorotation would use the info to adjust the frames.
> > ---
> >  fftools/ffmpeg.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 45 insertions(+)
>
> This breaks converting jpegs
>
> try this
> (file shoudl be here:
> https://trac.ffmpeg.org/raw-attachment/ticket/3424/bug.jpg)
>
> ./ffmpeg -i ~/tickets/3424/bug.jpg new.jpg
> ./ffmpeg -i ~/tickets/3424/bug.jpg new.bmp
>
> ./ffplay ~/tickets/3424/bug.jpg
> ./ffplay new.jpg
> ./ffplay new.bmp
>
> All 3 above should produce a image with the same and correct orientation
> they do before these 2 patches, they do not after
>
> Thanks
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Into a blind darkness they enter who follow after the Ignorance,
> they as if into a greater darkness enter who devote themselves
> to the Knowledge alone. -- Isha Upanishad
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


Thanks Michael for review and testing !
Yes, this is a bug in the patch. I missed the case when "Orientation" is 1,
which is horizontal(normal) .
Now the issue has been addressed in v2 as follows:
https://patchwork.ffmpeg.org/patch/13000/
https://patchwork.ffmpeg.org/patch/13001/

Best Regards,
Jun