[FFmpeg-devel] [PATCH] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

[Marc-Antoine ARNAUD]

Few remarks:
- For performances you have to align your data in the structure
AudioPhaseMeterContext: don't mix float, float array and bool. Put bool at
the end to align memory access.
- Use complete name and it's not a setter: set_meta, name it add_metadata.
- use inline functions for these functions: get_index, get_duration,
add_metadata.
- define contant in capitalised: pi becomes PI
- I think get_duration function can be defined as a macro.

Best,
Marc-Antoine



Le jeu. 9 mai 2019 à 10:35, Romane Lafon <romane at nomalab.com> a écrit :

> This patch extends aphasemeter filter to display metadata for out-of-phase
> or mono sequences of stereo streams.
> Displays start, end and duration as for silencedetect filter.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".