[FFmpeg-devel] [PATCH 1/2] VP4 video decoder

[Peter Ross]

On Sun, May 12, 2019 at 10:20:19AM -0300, James Almer wrote:
> On 5/12/2019 3:12 AM, Peter Ross wrote:
> > ---
> > i have incorporated all suggestions from the first patch posted jan 2019.
> > 
> > if there's nothing further to change, i will apply it a good week or so.
> > 
> > cheers,
> > 
> > 
> >  Changelog               |    1 +
> >  doc/general.texi        |    2 +
> >  libavcodec/allcodecs.c  |    1 +
> >  libavcodec/avcodec.h    |    1 +
> >  libavcodec/codec_desc.c |    7 +
> >  libavcodec/vp3.c        |  718 +++++++-
> >  libavcodec/vp4data.h    | 3784 +++++++++++++++++++++++++++++++++++++++
> >  7 files changed, 4478 insertions(+), 36 deletions(-)
> >  create mode 100644 libavcodec/vp4data.h
> 
> As Carl mentioned, this is missing a vp4_decoder_select line in
> configure to enable the vp3 decoder, like the theora one does. There's
> nothing telling the build system what objects are required for this new
> decoder otherwise.
> 
> Did you make sure Theora samples are unaffected? Those afaik are much
> more common in the wild than vp3. Wikimedia is full of them.

Unaffected :) I have tested this throughout development.

> Also, if you have distributable vp4 samples at hand, you should make at
> least one fate decoding test.

Shall do. I have no interesting content. Synthetic tests streams will have to suffice.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190513/3326bedc/attachment.sig>