[FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

Phil Burr phil.burr at gmail.com
Mon May 20 15:30:14 EEST 2019


Thank you for the feedback.  I will look into adding documentation for the
atsc metadata.  ATSC requires in addition to the tables I've added, the STT
and EIT0-EIT3 tables.  I'm thinking of adding support for STT and at least
producing empty EIT tables so that the stream would be minimally compliant.

Phil

On Sun, May 19, 2019 at 11:08 AM Devin Heitmueller <
dheitmueller at kernellabs.com> wrote:

> Hello Phillip,
>
> On Thu, May 16, 2019 at 9:32 AM Phillip Burr <phil.burr at gmail.com> wrote:
> >
> > Minimal support for ATSC PSIP tables.  Does not support STT or
> > EIT tables and so is not compliant with terrestrial ATSC.
> > ATSC tables are not created by default, and will only be transmitted
> > if either "atsc_name" or "atsc_channel" metadata is supplied.
>
> In general I am supportive of this effort (producing ATSC compliant
> streams).  Thanks for your work to improve the TS mux support in this
> area.
>
> While I haven't looked that closely at your implementation, one key
> thing missing is updated documentation that describes the new
> parameters, and in particular something that notes that streams
> generated are currently not fully compliant with the spec (as you
> noted, the lack of STT).  While it's good to have that in the patch
> description, that's something that really needs to be known to end
> users who might try to use the functionality.
>
> Regards,
>
> Devin
>
> --
> Devin J. Heitmueller - Kernel Labs
> http://www.kernellabs.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list