[FFmpeg-devel] [PATCHv4] VP4 video decoder

[Peter Ross]

On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote:
> Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne <dev at lynne.ee>:
> >
> > May 21, 2019, 8:44 AM by pross at xvid.org <mailto:pross at xvid.org>:
> >
> > > ---
> > >
> > > what's changed:
> > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks
> > > * improved vp4_read_mb_value thanks to reminars suggestions
> > > * improved configure vp3_decoder_select
> > >
> > >
> > > Changelog               |    1 +
> > > configure               |    1 +
> > > doc/general.texi        |    2 +
> > > libavcodec/Makefile     |    1 +
> > > libavcodec/allcodecs.c  |    1 +
> > > libavcodec/avcodec.h    |    1 +
> > > libavcodec/codec_desc.c |    7 +
> > > libavcodec/vp3.c        |  746 ++++++++++++++++++++++--
> > > libavcodec/vp4data.h    | 1186 +++++++++++++++++++++++++++++++++++++++
> > > 9 files changed, 1911 insertions(+), 35 deletions(-)
> > > create mode 100644 libavcodec/vp4data.h
> > >
> >
> > Just remove CONFIG_VP4_DECODER and make it part of the vp3 decoder.
> 
> Wasn't this explicitly requested in an earlier review?
> (And it is common within FFmpeg)

i'll leave the ifdefs inplace.

lynne has a point though, disabling vp4 only reduces the final ffmpeg binary by 25 kilobytes.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190523/6b49085f/attachment.sig>