[FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

[Pavel Koshevoy]

On Mon, Sep 2, 2019 at 10:40 AM Aman Gupta <ffmpeg at tmm1.net> wrote:
>
>
>
> On Mon, Sep 2, 2019 at 12:27 AM Pavel Koshevoy <pkoshevoy at gmail.com> wrote:
>>
>> ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0
>> which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init
>> failed and v4l2_m2m_destroy_context closed file descriptor 0 even
>> though it didn't belong to V4L2m2mContext.
>> ---
>>  libavcodec/v4l2_m2m.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c
>> index 427e165f58..ac583c811f 100644
>> --- a/libavcodec/v4l2_m2m.c
>> +++ b/libavcodec/v4l2_m2m.c
>> @@ -401,6 +401,7 @@ int ff_v4l2_m2m_create_context(AVCodecContext *avctx, V4L2m2mContext **s)
>>      priv->context->capture.num_buffers = priv->num_capture_buffers;
>>      priv->context->output.num_buffers  = priv->num_output_buffers;
>>      priv->context->self_ref = priv->context_ref;
>> +    priv->context->fd = -1;
>
>
>
> LGTM. I ran into the same problem last week and have a similar change in my tree.


Thanks, patch applied, pushed.

    Pavel.