[FFmpeg-devel] [PATCH] Add option to log timing

Soft Works softworkz at hotmail.com
Sat Sep 7 00:43:39 EEST 2019


> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Friday, September 6, 2019 8:56 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] Add option to log timing
> 
> On Wed, Sep 04, 2019 at 07:35:11PM +0000, Soft Works wrote:
> >
> > > Why this restriction? I think all log lines should be start with
> > > time/date if corresponding flag is present. This makes the log to be
> > > easy to parse by scripts.
> >
> > Initially I didn’t have this restriction, but it doesn’t work well together with
> some multi-line logging.
> > See below for an example.
> >
> > To get this nice, it would require a larger amount of changes, and probably
> result in something that nobody wants to merge in.
> >
> > Anyway, there’s a flag controlling this behavior and if you really want, you
> can set it.
> > Then you’ll see something like this:

[...]

> i just enabled prefixes for all calls, and i get this:
> 
> []   libavutil      56. 35.100 / 56. 35.100
> []   libavcodec     58. 56.101 / 58. 56.101

[...]

> 
> This looks much better than your example, so i have to disagree that theres a
> problem for calls during startup or some requirment of high complexity

I need to apologize. I had been driven by another complication that exists in 
my branch but not in the ffmpeg trunk.


I will submit an updated patch.

What would you prefer - should I:

1. Activate the flag for adding log timing  during startup by default
  (to allow opt-out behavior from the command line) or
2. Remove that flag and add log timing either all or nothing depending 
   On the other two flags?

Thanks,

softworkz



More information about the ffmpeg-devel mailing list