[FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

Michael Niedermayer michael at niedermayer.cc
Sat Sep 7 18:19:55 EEST 2019


On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote:
> Because lavf_container is sometimes called with only 2 arguments,
> fate tests produce bash errors like this:
> 
>   tests/fate-run.sh: 299: test: =: unexpected operator
> 
> This commit fixes this.
> ---
>  tests/fate-run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think this change is correct but shell is not my area ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190907/182825c2/attachment.sig>


More information about the ffmpeg-devel mailing list