[FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

Pascal Massimino pascal.massimino at gmail.com
Mon Sep 9 12:13:53 EEST 2019


Michael,

On Fri, Sep 6, 2019 at 6:21 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Fri, Sep 06, 2019 at 01:11:50PM +0200, Pascal Massimino wrote:
> > Michael,
> >
> > On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer
> <michael at niedermayer.cc>
> > wrote:
> >
> > > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote:
> [...]
>
> > >
> > > i would guess its not a known chunk but rather hits the default
> > > is that just a bunch of 0 or 0xFF bytes ?
> > > detecting before we read into the end feels more robust if
> > > we can simply detect the "junk"
> > >
> >
> > As i mentioned in the description, a possibly more robust solution would
> be
> > just stopping the loop as soon as 'chunk_size' bytes have been consumed
> > (leading to *got_frame = 1) and no more. This current patch is
> minimalist,
> > though.
>
> well, which solution do you prefer ?
>

the one in the patch is fine.

skal/


>
> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list