[FFmpeg-devel] [PATCH] avcodec/h2645_parse: simplify memset call

Limin Wang lance.lmwang at gmail.com
Tue Sep 10 04:24:14 EEST 2019


On Sat, Sep 07, 2019 at 03:55:51PM -0400, Andriy Gelman wrote:
> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Removed (new_size - pkt->nals_allocated) because this value is always 1
> during the call.
> ---
>  libavcodec/h2645_parse.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
> index 307e8643e6..ef6a6b4b4f 100644
> --- a/libavcodec/h2645_parse.c
> +++ b/libavcodec/h2645_parse.c
> @@ -461,8 +461,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length,
>                  return AVERROR(ENOMEM);
>  
>              pkt->nals = tmp;
> -            memset(pkt->nals + pkt->nals_allocated, 0,
> -                   (new_size - pkt->nals_allocated) * sizeof(*pkt->nals));
> +            memset(pkt->nals + pkt->nals_allocated, 0, sizeof(*pkt->nals));

instead, I think the new_size isn't set properly  please refer to my patch in the thread.


>  
>              nal = &pkt->nals[pkt->nb_nals];
>              nal->skipped_bytes_pos_size = 1024; // initial buffer size
> -- 
> 2.23.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list