[FFmpeg-devel] [PATCH V1 3/4] lavf/avidec: fix memory leak in error handling path

Jun Zhao mypopydev at gmail.com
Tue Sep 10 14:39:27 EEST 2019


From: Jun Zhao <barryjzhao at tencent.com>

free the value in error handling path to avoid the memory leak.

Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
---
 libavformat/avidec.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/libavformat/avidec.c b/libavformat/avidec.c
index df78925..e3cd844 100644
--- a/libavformat/avidec.c
+++ b/libavformat/avidec.c
@@ -306,8 +306,10 @@ static int avi_read_tag(AVFormatContext *s, AVStream *st, uint32_t tag,
     value = av_malloc(size + 1);
     if (!value)
         return AVERROR(ENOMEM);
-    if (avio_read(pb, value, size) != size)
+    if (avio_read(pb, value, size) != size) {
+        av_freep(&value);
         return AVERROR_INVALIDDATA;
+    }
     value[size] = 0;
 
     AV_WL32(key, tag);
-- 
1.7.1



More information about the ffmpeg-devel mailing list