[FFmpeg-devel] [PATCH v2 2/8] avformat/internal: Improve documentation of ff_packet_list_get

Michael Niedermayer michael at niedermayer.cc
Wed Sep 18 23:57:46 EEST 2019


On Mon, Aug 19, 2019 at 11:56:18PM +0200, Andreas Rheinhardt wrote:
> The documentation of ff_packet_list_get currently didn't match the
> actual usage:
> 1. It said that the destination packet is supposed to be initialized.
> But this makes no sense given that it will be overwritten completely and
> flacenc, mp3enc and ttaenc ignored this.
> 2. ff_packet_list_get returns an int, although it can't fail in case the
> packet list is not empty (for which there is an assert). Again, several
> callers didn't check for any return value.
> In both cases, the documentation has been adapted to match actual usage.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> No changes since last time.
> 
>  libavformat/internal.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190918/451ecdb4/attachment.sig>


More information about the ffmpeg-devel mailing list