[FFmpeg-devel] [PATCH v2 3/8] avformat/utils: Preserve integrity of linked list

Michael Niedermayer michael at niedermayer.cc
Wed Sep 18 23:59:00 EEST 2019


On Mon, Aug 19, 2019 at 11:56:19PM +0200, Andreas Rheinhardt wrote:
> 1. Instead of relying on ff_packet_list_get to get the oldest element in
> an AVPacketList, ff_read_packet used its own ad-hoc code. Said code
> forgot to set the end of the list to NULL if the last element of the
> list has been removed, thereby leaving the list in an inconsistent state.
> 2. Furthermore, if the list was not empty, the oldest element of the
> list would always be copied into another packet structure before it was
> known whether the oldest entry of the list would be removed. This makes
> the ownership confusing and potentially copies unnecessarily.
> 
> Both of these issues have been fixed. ff_packet_list_get is used now.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> No changes since last time.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190918/b4d46abc/attachment.sig>


More information about the ffmpeg-devel mailing list