[FFmpeg-devel] [PATCH] tools/patcheck: remove gcc-2.95 compat check

James Zern jzern at google.com
Fri Sep 20 10:09:05 EEST 2019


this conflicts with the current contributing guidance:
http://ffmpeg.org/developer.html#Contributing
FFmpeg is programmed in the ISO C90 language with a few additional
features from ISO C99, namely:
...
for loops with variable definition (‘for (int i = 0; i < 8; i++)’);

Signed-off-by: James Zern <jzern at google.com>
---
 tools/patcheck | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/patcheck b/tools/patcheck
index 101a542ff3..fe52938f29 100755
--- a/tools/patcheck
+++ b/tools/patcheck
@@ -50,7 +50,6 @@ hiegrep ';;'              'double ;' $*
 hiegrep2 '\b_[a-zA-Z0-9_]{1,}' '__(asm|attribute)([^a-zA-Z0-9]|$)' 'reserved identifer' $*
 hiegrep '//[-/<\* ]*$'    'empty comment' $*
 hiegrep '/\*[-<\* ]*\*/'  'empty comment' $*
-hiegrep 'for *\( *'"$ERE_PRITYP"' '  'not gcc 2.95 compatible' $*
 hiegrep '(static|inline|const) *\1[^_a-zA-Z]'  'duplicate word' $*
 hiegrep 'INIT_VLC_USE_STATIC' 'forbidden ancient vlc type' $*
 hiegrep '=[-+\*\&] ' 'looks like compound assignment' $*
-- 
2.23.0.351.gc4317032e6-goog



More information about the ffmpeg-devel mailing list