[FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

[Song, Ruiling]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Li,
> Zhong
> Sent: Tuesday, September 24, 2019 2:34 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for
> vf_eq
> 
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Ting Fu
> > Sent: Wednesday, September 18, 2019 3:06 PM
> > To: ffmpeg-devel at ffmpeg.org
> > Subject: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for
> vf_eq
> >
> > Signed-off-by: Ting Fu <ting.fu at intel.com>
> > ---
> >  libavfilter/vf_eq.c       | 13 ++++---
> >  libavfilter/vf_eq.h       |  1 +
> >  tests/checkasm/Makefile   |  1 +
> >  tests/checkasm/checkasm.c |  3 ++
> >  tests/checkasm/checkasm.h |  1 +
> >  tests/checkasm/vf_eq.c    | 79
> +++++++++++++++++++++++++++++++++++++++
[...]
> > +    declare_func(void, EQParameters *param, uint8_t *dst, int dst_stride,
> > +                 const uint8_t *src, int src_stride, int w, int h);
> > +
> > +    memset(src,     0, PIXELS);
> 
> Looks it is redundant with randomize_buffers() and make performance drop
Will remove and apply.
> 
> > +    memset(dst_ref, 0, PIXELS);
> > +    memset(dst_new, 0, PIXELS);
> > +    randomize_buffers(src, PIXELS);
> > +    ff_eq_init(&eq);
> > +
[...]