[FFmpeg-devel] [PATCH 2/9] avformat/s337m: Split read_packet/get_packet

[Tomas Härdin]

fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier:
> Prepare use of s337m_get_packet from outside.
> ---
>  libavformat/s337m.c | 28 +++++++++++++++++++++-------
>  libavformat/s337m.h | 38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 7 deletions(-)
>  create mode 100644 libavformat/s337m.h

> diff --git a/libavformat/s337m.h b/libavformat/s337m.h
> new file mode 100644
> index 0000000000..86d2da6f57
> --- /dev/null
> +++ b/libavformat/s337m.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (C) 2017 foo86

Maybe update this?

> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVFORMAT_S337M_H
> +#define AVFORMAT_S337M_H
> +
> +/**
> + * Read s337m packets in a PCM_S16LE/S24LE stereo stream
> + * Returns the first inner packet found
> + * Note that it does not require a clean guard band
> + * @param pb Associated IO context
> + * @param pkt On success, returns a DOLBY E packet
> + * @param size Maximum IO read size available for reading at current position
> + * @param codec Returns AV_CODEC_ID_DOLBY_E
> + * @param avc For av_log
> + * @return = 0 on success (an error is raised if no s337m was found)
> + */
> +int ff_s337m_get_packet(AVIOContext *pb, AVPacket *pkt, int size, enum AVCodecID *codec, void *avc);
> +
> +int ff_s337m_read_packet(AVFormatContext *s, AVPacket *pkt);

Maybe a docstring for this one too

Rest of the patch looks OK

/Tomas