[FFmpeg-devel] [PATCH v3] Add avpriv_slicethread_create2() and avpriv_slicethread_execute2(), make execute() and execute2() return FFMIN() of thread return codes

[Tomas Härdin]

mån 2022-09-26 klockan 10:54 -0300 skrev James Almer:
> On 9/26/2022 10:50 AM, Andreas Rheinhardt wrote:
> > Tomas Härdin:
> > > diff --git a/doc/APIchanges b/doc/APIchanges
> > > index b0a41c9e37..240e549a2f 100644
> > > --- a/doc/APIchanges
> > > +++ b/doc/APIchanges
> > > @@ -14,6 +14,10 @@ libavutil:     2021-04-27
> > >   
> > >   API changes, most recent first:
> > >   
> > > +2022-09-26 - xxxxxxxxxx - lavu 57.38.100 - slicethread.h
> > > +  Deprecate avpriv_slicethread_create() and
> > > avpriv_slicethread_execute().
> > > +  Add avpriv_slicethread_create2() and
> > > avpriv_slicethread_execute2().
> > > +
> > 
> > This is not public API and therefore no entry in APIchanges is
> > necessary
> > or warranted.
> 
> And for the same reason there's no need to use the deprecated
> attribute 
> on them.
> 
> Also, maybe wrap all the old stuff in LIBAVUTIL_VERSION_MAJOR < 58 
> checks so they are disabled gone as soon as we bump major, or at
> least 
> make some noise so we don't forget about it.

Updated patch attached

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-avpriv_slicethread_create2-and-avpriv_slicethrea.patch
Type: text/x-patch
Size: 22283 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220926/3fcc77b9/attachment.bin>