[FFmpeg-trac] #2512(avcodec:new): FF_API_DESTRUCT_PACKET is incompletely deprecating use of API

[FFmpeg]

#2512: FF_API_DESTRUCT_PACKET is incompletely deprecating use of API
----------------------------------+---------------------------------------
             Reporter:  wolenetz  |                     Type:  defect
               Status:  new       |                 Priority:  normal
            Component:  avcodec   |                  Version:  unspecified
             Keywords:            |               Blocked By:
             Blocking:            |  Reproduced by developer:  0
Analyzed by developer:  0         |
----------------------------------+---------------------------------------
 Summary of the bug:
 If FF_API_DESTRUCT_PACKET is not defined, there are currently some pieces
 that fail to build in FFmpeg.

 Currently, FF_API_DESTRUCT_PACKET is gated on lavc major version < 56, so
 it is defined by default and these build errors are not hit.  Until full
 removal of this deprecated API, users of ffmpeg, such as chromium, that
 warn on deprecated attribute and error on warnings, currently require
 downstream patches to disable deprecated attribute while keeping
 FF_API_DESTRUCT_PACKET defined as true.

 Are these build errors known and work planned to fix them prior to full
 deprecation of this API?

 How to reproduce:
 Examples of build failures when FF_API_DESTRUCT_PACKET is defined as false
 (1 < 1) in lavc/version.h:

 lavc/avpacket.c:217:5: error: av_destruct_packet(pkt) is called but there
 is no declaration or definition of it

 lavc/utils.c: multiple errors due to use of undeclared member named
 'destruct' in 'struct AVPacket'

-- 
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2512>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker