[FFmpeg-trac] #3554(avdevice:new): lavfi.c: variable 'sink' is used uninitialized whenever type == AVMEDIA_TYPE_AUDIO

FFmpeg trac at avcodec.org
Mon Apr 14 01:15:29 CEST 2014


#3554: lavfi.c: variable 'sink' is used uninitialized whenever type ==
AVMEDIA_TYPE_AUDIO
-------------------------------------+------------------------------------
             Reporter:  jeremyhu     |                    Owner:
                 Type:  defect       |                   Status:  new
             Priority:  normal       |                Component:  avdevice
              Version:  unspecified  |               Resolution:
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+------------------------------------

Comment (by DonMoir):

 ...
 AVFilterContext *sink;
 ...
 if (type == AVMEDIA_TYPE_VIDEO) {
     ...
     ... ok sink set
 }
 else if (type == AVMEDIA_TYPE_AUDIO) {
     ...
     ... ok sink set
 }
 else {
    sink not set - remove test for audio if only can be video/audio
 otherwise maybe
    skip it, error, set to null, or who knows.
 }

 lavfi->sinks[i] = sink;
 ...

--
Ticket URL: <https://trac.ffmpeg.org/ticket/3554#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list