[FFmpeg-trac] #3806(avformat:new): http: get_cookies() breaks for cookies with unexpected parameters and for parameters with spaces

[FFmpeg]

#3806: http: get_cookies() breaks for cookies with unexpected parameters and for
parameters with spaces
-------------------------------------+-------------------------------------
             Reporter:  cakemonster  |                     Type:  defect
               Status:  new          |                 Priority:  normal
            Component:  avformat     |                  Version:  git-
             Keywords:  http cookie  |  master
             Blocking:               |               Blocked By:
Analyzed by developer:  0            |  Reproduced by developer:  0
-------------------------------------+-------------------------------------
 If a site sets a cookie that includes (for example) the !HttpOnly
 parameter get_cookies() fails to return that cookie for use with
 subsequent requests. Instead "Cookie: !HttpOnly" is sent to the server.

 Also if a site sets the Expires parameter (which includes spaces by
 definition) the parsing breaks due to the "; " delimiter list to av_strtok
 and "Cookie: GMT" will be sent instead of the real cookie.

 Ugly hack that fixes these 2 cases but will break for any other unknown
 cookie parameters attached.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/3806>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker