[FFmpeg-trac] #4423(avformat:new): Set AV_DISPOSITION_ATTACHED_PIC for MKV Cover Art

[FFmpeg]

#4423: Set AV_DISPOSITION_ATTACHED_PIC for MKV Cover Art
-----------------------------------+------------------------------------
             Reporter:  malaterre  |                    Owner:
                 Type:  defect     |                   Status:  new
             Priority:  normal     |                Component:  avformat
              Version:  2.6.1      |               Resolution:
             Keywords:             |               Blocked By:
             Blocking:             |  Reproduced by developer:  0
Analyzed by developer:  0          |
-----------------------------------+------------------------------------

Comment (by cehoyos):

 Replying to [ticket:4423 malaterre]:
 > minidlna currently uses the following piece of code to find Cover Art:
 >
 > https://sourceforge.net/p/minidlna/git/ci/master/tree/libav.h#l171
 > [...]
 >       if (s->disposition & AV_DISPOSITION_ATTACHED_PIC &&
 >           s->codec->codec_id == AV_CODEC_ID_MJPEG)

 Shouldn't this be:
 {{{
     if ((s->disposition & AV_DISPOSITION_ATTACHED_PIC ||
 s->codec->codec_type == AVMEDIA_TYPE_ATTACHMENT) &&
         s->codec->codec_id == AV_CODEC_ID_MJPEG)
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4423#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker